linux-kernel - Re: [PATCH 1/2] Add support for Cadence XSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202012091838.AfpICqxM-lkp@intel.com>
Date:   Wed, 9 Dec 2020 18:28:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jayshri Pawar <jpawar@...ence.com>, linux-spi@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, miquel.raynal@...tlin.com, richard@....at,
        vigneshr@...com, linux-kernel@...r.kernel.org,
        dkangude@...ence.com, mparab@...ence.com, sjakhade@...ence.com,
        jpawar@...ence.com, Konrad Kociolek <konrad@...ence.com>
Subject: Re: [PATCH 1/2] Add support for Cadence XSPI controller

Hi Jayshri,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.10-rc7 next-20201208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jayshri-Pawar/Driver-for-Cadence-xSPI-flash-controller/20201209-160406
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5b258ff21564ca007e3b54d865c3cfb9851ed00a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jayshri-Pawar/Driver-for-Cadence-xSPI-flash-controller/20201209-160406
        git checkout 5b258ff21564ca007e3b54d865c3cfb9851ed00a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/sparc/include/asm/io.h:5,
                    from include/linux/io.h:13,
                    from drivers/spi/spi-cadence-xspi.c:15:
   drivers/spi/spi-cadence-xspi.c: In function 'cdns_xspi_send_stig_command':
>> arch/sparc/include/asm/io_64.h:179:2: warning: '*((void *)&cmd_regs+20)' is used uninitialized in this function [-Wuninitialized]
     179 |  __asm__ __volatile__("stwa\t%r0, [%1] %2\t/* pci_writel */"
         |  ^~~~~~~
   drivers/spi/spi-cadence-xspi.c:521:6: note: '*((void *)&cmd_regs+20)' was declared here
     521 |  u32 cmd_regs[5] = {0};
         |      ^~~~~~~~

vim +179 arch/sparc/include/asm/io_64.h

f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  174  
79294d7eff89f65 arch/sparc/include/asm/io_64.h Sam Ravnborg  2014-07-20  175  #define writel writel
7c3969c3a4f3593 arch/sparc/include/asm/io_64.h Arnd Bergmann 2014-11-19  176  #define writel_relaxed writel
79294d7eff89f65 arch/sparc/include/asm/io_64.h Sam Ravnborg  2014-07-20  177  static inline void writel(u32 l, volatile void __iomem *addr)
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  178  {
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17 @179  	__asm__ __volatile__("stwa\t%r0, [%1] %2\t/* pci_writel */"
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  180  			     : /* no outputs */
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  181  			     : "Jr" (l), "r" (addr), "i" (ASI_PHYS_BYPASS_EC_E_L)
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  182  			     : "memory");
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  183  }
f5e706ad886b6a5 include/asm-sparc/io_64.h      Sam Ravnborg  2008-07-17  184  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67969 bytes)