linux-kernel - Re: [PATCH] USB: serial: option: add interface-number sanity check to flag handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9CsfckIiLGSrK/o@kroah.com>
Date:   Wed, 9 Dec 2020 11:52:45 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+8881b478dad0a7971f79@...kaller.appspotmail.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: add interface-number sanity check
 to flag handling

On Wed, Dec 09, 2020 at 11:42:21AM +0100, Johan Hovold wrote:
> Add an interface-number sanity check before testing the device flags to
> avoid relying on undefined behaviour when left shifting in case a device
> uses an interface number greater than or equal to BITS_PER_LONG (i.e. 64
> or 32).
> 
> Reported-by: syzbot+8881b478dad0a7971f79@...kaller.appspotmail.com
> Fixes: c3a65808f04a ("USB: serial: option: reimplement interface masking")
> Cc: stable@...r.kernel.org
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>