linux-kernel - Re: [PATCH] PCI: Remove pci_try_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VezKrQAVf4ceJnHq5R8niwMqCme5N5dW0deyVYP3GjO8A@mail.gmail.com>
Date:   Wed, 9 Dec 2020 13:02:01 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>,
        Viresh Kumar <vireshk@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        David Miller <davem@...emloft.net>,
        Lee Jones <lee.jones@...aro.org>,
        Ion Badulescu <ionut@...ula.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Adam Radford <aradford@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Peter Chen <Peter.Chen@....com>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-ide@...r.kernel.org, dmaengine <dmaengine@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-parisc@...r.kernel.org,
        linux-wireless <linux-wireless@...r.kernel.org>,
        SCSI development list <linux-scsi@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] PCI: Remove pci_try_set_mwi

On Wed, Dec 9, 2020 at 12:59 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Wed, Dec 9, 2020 at 10:35 AM Heiner Kallweit <hkallweit1@...il.com> wrote:

...

> > -int pci_try_set_mwi(struct pci_dev *dev)
> > -{
>
> > -#ifdef PCI_DISABLE_MWI
> > -       return 0;
> > -#else
> > -       return pci_set_mwi(dev);
> > -#endif
>
> This seems still valid case for PowerPC and SH.

I see that pci_set_mwi() also has the ifdeffery (I thought it's only
here), so it's fine.

> > -}
> > -EXPORT_SYMBOL(pci_try_set_mwi);

-- 
With Best Regards,
Andy Shevchenko