linux-kernel - Re: [PATCH] iov_iter: optimise bvec iov_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcfd61df-23cd-fb56-5d7a-47ee2f025739@gmail.com>
Date:   Wed, 9 Dec 2020 12:06:55 +0000
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()

On 09/12/2020 08:33, Christoph Hellwig wrote:
> On Thu, Dec 03, 2020 at 11:48:56AM +0000, Pavel Begunkov wrote:
>> It's inlined and the on-stack iter is completely optimised out. Frankly,
>> I'd rather not open-code bvec_iter_advance(), at least for this chunk to
>> be findable from bvec.h, e.g. grep bvec_iter and bvec_for_each. Though,
>> I don't like myself that preamble/postamble.
> 
> Ok.  I still think we at least want a separate helper instead of
> bloating the main iov_iter_advance.

I agree on that, just haven't got back to it yet.

-- 
Pavel Begunkov