linux-kernel - Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d41c7f60-c9ea-f37b-65ed-4c9b4f5703a0@windriver.com>
Date:   Wed, 9 Dec 2020 09:14:47 +0800
From:   "quanyang.wang" <quanyang.wang@...driver.com>
To:     Michal Simek <michal.simek@...inx.com>, mturquette@...libre.com,
        sboyd@...nel.org
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP
 automatically

Hi Michal,

On 12/8/20 8:42 PM, Michal Simek wrote:
> Hi,
>
> On 08. 12. 20 13:35, quanyang.wang@...driver.com wrote:
>> From: Quanyang Wang <quanyang.wang@...driver.com>
>>
>> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
>> so we need to enable it when ARCH_ZYNQMP is selected.
>>
>> Signed-off-by: Quanyang Wang <quanyang.wang@...driver.com>
>> ---
>>   drivers/clk/zynqmp/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
>> index 17086059be8b..a8aa58bbb790 100644
>> --- a/drivers/clk/zynqmp/Kconfig
>> +++ b/drivers/clk/zynqmp/Kconfig
>> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>>   	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>>   	depends on ARCH_ZYNQMP || COMPILE_TEST
>>   	depends on ZYNQMP_FIRMWARE
>> +	default ARCH_ZYNQMP
> This is not right. If you look 2 lines above.
>
>>   	help
>>   	  Support for the Zynqmp Ultrascale clock controller.
>>   	  It has a dependency on the PMU firmware.
>>
> And we were talking about enabling this driver in defconfig. Not via
> Kconfig. This fragment was designed in a way that this clock controller
> doesn't need to be used. It is our default but if you want to use for
> example fixed clock you also can.
> This enables space for being able to use for example different firmware.

Thanks for your reply. I will enable this driver in defconfig.

Best Regards

Quanyang

>
> Thanks,
> Michal