linux-kernel - Re: [Linux-stm32] [PATCH] remoteproc: stm32: don't print an error on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2b81c79-2879-f469-0805-99d542f1cd93@foss.st.com>
Date:   Wed, 9 Dec 2020 15:41:44 +0100
From:   Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
CC:     Etienne Carriere <etienne.carriere@...com>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [Linux-stm32] [PATCH] remoteproc: stm32: don't print an error on
 probe deferral



On 12/9/20 3:06 PM, Ahmad Fatoum wrote:
> Hello Arnaud,
> 
> On Wed, 2020-12-09 at 14:12 +0100, Arnaud Pouliquen wrote:
>> From: Etienne Carriere <etienne.carriere@...com>
>>
>> Change stm32 remoteproc driver to not generate an error message
>> when device probe operation is deferred for the reset controller.
>>
>> Signed-off-by: Etienne Carriere <etienne.carriere@...com>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>
>> ---
>>  drivers/remoteproc/stm32_rproc.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/stm32_rproc.c
>> b/drivers/remoteproc/stm32_rproc.c
>> index a180aeae9675..25c916782991 100644
>> --- a/drivers/remoteproc/stm32_rproc.c
>> +++ b/drivers/remoteproc/stm32_rproc.c
>> @@ -614,7 +614,9 @@ static int stm32_rproc_parse_dt(struct
>> platform_device *pdev,
>>  
>>  	ddata->rst = devm_reset_control_get_by_index(dev, 0);
>>  	if (IS_ERR(ddata->rst)) {
>> -		dev_err(dev, "failed to get mcu reset\n");
>> +		if (PTR_ERR(ddata->rst) != -EPROBE_DEFER)
>> +			dev_err(dev, "failed to get mcu reset\n");
>> +
> 
> There is dev_err_probe() now that could be used here instead.
> It has the added benefit that it records the reason for the
> deferred probe.

Thanks for the advice, I will test it!

> 
>>  		return PTR_ERR(ddata->rst);
>>  	}
>>  
>