linux-kernel - Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in temac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201208.161650.1190066192708878176.davem@davemloft.net>
Date:   Tue, 08 Dec 2020 16:16:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     zhangchangzhong@...wei.com
Cc:     kuba@...nel.org, michal.simek@...inx.com, esben@...nix.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in
 temac_probe()

From: Zhang Changzhong <zhangchangzhong@...wei.com>
Date: Tue, 8 Dec 2020 09:53:42 +0800

> platform_get_resource() may fail and in this case a NULL dereference
> will occur.
> 
> Fix it to use devm_platform_ioremap_resource() instead of calling
> platform_get_resource() and devm_ioremap().
> 
> This is detected by Coccinelle semantic patch.
> 
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
> 
> res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
> + if (!res)
> +   return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
> 
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Applied, thanks.