| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20201209143707.13503-1-erez.geva.ext@siemens.com>
Date: Wed, 9 Dec 2020 15:37:03 +0100
From: Erez Geva <erez.geva.ext@...mens.com>
To: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arch@...r.kernel.org,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
Arnd Bergmann <arnd@...db.de>,
Cong Wang <xiyou.wangcong@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
Jakub Kicinski <kuba@...nel.org>,
Jamal Hadi Salim <jhs@...atatu.com>,
Jiri Pirko <jiri@...nulli.us>,
Alexei Starovoitov <ast@...nel.org>,
Colin Ian King <colin.king@...onical.com>,
Daniel Borkmann <daniel@...earbox.net>,
Eric Dumazet <edumazet@...gle.com>,
Eyal Birger <eyal.birger@...il.com>,
"Gustavo A . R . Silva" <gustavoars@...nel.org>,
Jakub Sitnicki <jakub@...udflare.com>,
John Ogness <john.ogness@...utronix.de>,
Jon Rosen <jrosen@...co.com>,
Kees Cook <keescook@...omium.org>,
Mao Wenan <maowenan@...wei.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Martin KaFai Lau <kafai@...com>,
Matthieu Baerts <matthieu.baerts@...sares.net>,
Andrei Vagin <avagin@...il.com>,
Dmitry Safonov <0x7f454c46@...il.com>,
"Eric W . Biederman" <ebiederm@...ssion.com>,
Ingo Molnar <mingo@...nel.org>,
John Stultz <john.stultz@...aro.org>,
Miaohe Lin <linmiaohe@...wei.com>,
Michal Kubecek <mkubecek@...e.cz>,
Or Cohen <orcohen@...oaltonetworks.com>,
Oleg Nesterov <oleg@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Richard Cochran <richardcochran@...il.com>,
Stefan Schmidt <stefan@...enfreihafen.org>,
Willem de Bruijn <willemb@...gle.com>,
Xie He <xie.he.0141@...il.com>,
Stephen Boyd <sboyd@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Vladis Dronov <vdronov@...hat.com>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Frederic Weisbecker <frederic@...nel.org>
Cc: Vinicius Costa Gomes <vinicius.gomes@...el.com>,
Vedang Patel <vedang.patel@...el.com>,
Ines Molzahn <ines.molzahn@...mens.com>,
Simon Sudler <simon.sudler@...mens.com>,
Andreas Meisinger <andreas.meisinger@...mens.com>,
Andreas Bucher <andreas.bucher@...mens.com>,
Henning Schild <henning.schild@...mens.com>,
Jan Kiszka <jan.kiszka@...mens.com>,
Andreas Zirkler <andreas.zirkler@...mens.com>,
Ermin Sakic <ermin.sakic@...mens.com>,
An Ninh Nguyen <anninh.nguyen@...mens.com>,
Michael Saenger <michael.saenger@...mens.com>,
Bernd Maehringer <bernd.maehringer@...mens.com>,
Gisela Greinert <gisela.greinert@...mens.com>,
Erez Geva <erez.geva.ext@...mens.com>,
Erez Geva <ErezGeva2@...il.com>
Subject: [PATCH 0/3] Add sending TX hardware timestamp for TC ETF Qdisc
Add support for TX sending hardware timestamp with
Traffic control Earliest TxTime First (ETF) Qdisc.
Why do we need additional timestamp?
Current ETF requires to synchronization the system clock
to the PTP Hardware clock (PHC) we want to send through.
But there are cases that we can not synchronize the system clock with
the desired NIC PHC.
1. We use several NICs with several PTP domains that our device
is not allowed to be PTP master of.
2. We are using another clock source which we need for our system.
Yet our device is not allowed to be PTP master.
Regardless of the exact topology, as the Linux tradition is to allow
the user the freedom to choose,
we propose a patch that will add a hardware timestamp to the packet.
The TC-ETF will use the first timestamp and compare it with
the system clock while send the packet to the network interface driver
with that hardware timestamp that is correlated with the PHC.
Note 1: we do encourage the users to synchronize the system clock with
a PTP clock. Synchronizing the system clock with a PTP clock will
reduce the frequency difference of the PHC and the system clock,
increase the accurecy and may enable the user to reduce the ETF delta.
Note 2: In our network usage models sending a frame has to be very
precise in relation to the PHC. Our user application does have
the exact send time as of PHC perspective so it is able
to provide the hw timestamp.
Note 3: The user can estimate the clocks conversion error done
in the user application and add it to the delta setting of the ETF.
The patches contain:
1. A new flag for the SO_TXTIME socket option.
2. A new cmsg header, SCM_HW_TXTIME to pass the TX hardware timestamp.
3. Add the hardware timestamp to the socket cookie and to the inet cork.
4. As ETF Qdisc is irrelevant to TCP, ignore the TCP.
5. A new flag to the ETF Qdisc setting that mandate
the use of the hardware timestamp in the SKB.
6. The ETF sort packets according to hardware timestamp,
Yet pass the packet to network interface driver based
on the system clock timestamp.
Note 4: The socket buffer hardware timestamp is used by
the network interface driver to send the actual sending timestamp
back to the application. The timestamp is used by the TC ETF
before the socket buffer arrives in the network interface driver.
Erez Geva (3):
Add TX sending hardware timestamp.
Pass TX sending hardware timestamp to a socket's buffer.
The TC ETF Qdisc pass the hardware timestamp to the interface driver.
include/net/inet_sock.h | 1 +
include/net/sock.h | 2 ++
include/uapi/asm-generic/socket.h | 3 ++
include/uapi/linux/net_tstamp.h | 3 +-
include/uapi/linux/pkt_sched.h | 1 +
net/core/sock.c | 9 +++++
net/ipv4/ip_output.c | 2 ++
net/ipv4/raw.c | 1 +
net/ipv6/ip6_output.c | 2 ++
net/ipv6/raw.c | 1 +
net/packet/af_packet.c | 3 ++
net/sched/sch_etf.c | 59 +++++++++++++++++++++++++------
12 files changed, 75 insertions(+), 12 deletions(-)
base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
--
2.20.1
Powered by blists - more mailing lists