linux-kernel - Re: [PATCH v3] scsi: NCR5380: Remove context check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160753457755.14816.7863858983010100701.b4-ty@oracle.com>
Date:   Wed,  9 Dec 2020 12:23:13 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Finn Thain <fthain@...egraphics.com.au>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Sebastian A. Siewior" <bigeasy@...utronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Michael Schmitz <schmitzmic@...il.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH v3] scsi: NCR5380: Remove context check

On Sun, 6 Dec 2020 08:51:57 +0100, Ahmed S. Darwish wrote:

> NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to
> check if it is safe to sleep.
> 
> Such usage in drivers is phased out and Linus clearly requested that
> code which changes behaviour depending on context should either be
> separated, or the context be explicitly conveyed in an argument passed
> by the caller.
> 
> [...]

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: NCR5380: Remove context check
      https://git.kernel.org/mkp/scsi/c/e7734ef14ead

-- 
Martin K. Petersen	Oracle Linux Engineering