linux-kernel - Re: Re: Re: [PATCH] staging: rtl8712: check register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7111e709.212e.1764d3e89da.Coremail.shaojie.dong@isrc.iscas.ac.cn>
Date:   Thu, 10 Dec 2020 23:21:52 +0800 (GMT+08:00)
From:   shaojie.dong@...c.iscas.ac.cn
To:     "Dan Carpenter" <dan.carpenter@...cle.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: Re: [PATCH] staging: rtl8712: check register_netdev()
 return value

Hi

I do not have rtl8712 hardware
So that I would remain this code and give up my patch
Thank you !

&gt; -----原始邮件-----
&gt; 发件人: "Dan Carpenter" <dan.carpenter@...cle.com>
&gt; 发送时间: 2020-12-10 23:16:31 (星期四)
&gt; 收件人: shaojie.dong@...c.iscas.ac.cn
&gt; 抄送: Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
&gt; 主题: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value
&gt; 
&gt; On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.dong@...c.iscas.ac.cn wrote:
&gt; &gt; Hi
&gt; &gt; 
&gt; &gt; &gt; 
&gt; &gt; &gt; This function should not be calling register_netdev().  What does that
&gt; &gt; &gt; have to do with firmware?  It should also not free_netdev() because
&gt; &gt; &gt; that will just lead to a use after free in the caller.
&gt; &gt; &gt;
&gt; &gt; 
&gt; &gt; --&gt; check code history author<larry.finger@...inger.net> changed synchronous firmware loading to asynchronous firmware loading
&gt; &gt;     before this change, register_netdev() was not calling in firmware related function.
&gt; &gt;     For asynchronous loading, maybe register_netdev() be calling in rtl871x_load_fw_cb() is to ensure the netdev be registered after firmware loading completed
&gt; &gt; 
&gt; &gt; --&gt; for potential use after free issue
&gt; &gt;     Could I only call "free_irq(adapter-&gt;pnetdev-&gt;irq, adapter-&gt;pnetdev)" when register_netdev() failed ?
&gt; &gt;     If no need to change drivers/staging/rtl8712/hal_init.c file, I could give up my patch, thank you !
&gt; &gt; 
&gt; 
&gt; Cleaning this up is a bit complicated and requires reworking the
&gt; firmware loading and it requires testing.  I don't think you have the
&gt; hardware to actually test this driver?  Probably, just leave this code
&gt; for another day.
&gt; 
&gt; regards,
&gt; dan carpenter
</larry.finger@...inger.net></dan.carpenter@...cle.com>