linux-kernel - Re: [PATCH v5 4/5] Driver core: platform: Add devm_platform_get_irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9I+2ydy8VDOaiec@kroah.com>
Date:   Thu, 10 Dec 2020 16:29:31 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Marc Zyngier <maz@...nel.org>
Cc:     John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, lenb@...nel.org, rjw@...ysocki.net,
        tglx@...utronix.de, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        linux-acpi@...r.kernel.org, dwagner@...e.de
Subject: Re: [PATCH v5 4/5] Driver core: platform: Add
 devm_platform_get_irqs_affinity()

On Wed, Dec 09, 2020 at 07:39:03PM +0000, Marc Zyngier wrote:
> On 2020-12-09 19:13, Greg KH wrote:
> > On Wed, Dec 09, 2020 at 07:04:02PM +0000, John Garry wrote:
> > > On 09/12/2020 18:32, Greg KH wrote:
> > > > On Wed, Dec 02, 2020 at 06:36:56PM +0800, John Garry wrote:
> > > > > Drivers for multi-queue platform devices may also want managed interrupts
> > > > > for handling HW queue completion interrupts, so add support.
> > > >
> > > 
> > > Hi Greg,
> > > 
> > > > Why would a platform device want all of this?  Shouldn't such a device
> > > > be on a "real" bus instead?
> > > 
> > > For this HW version, the device is on the system bus, directly
> > > addressable
> > > by the CPU.
> > 
> > What do you mean by "system bus"?
> > 
> > > Motivation is that I wanted to switch the HW completion queues to use
> > > managed interrupts.
> > 
> > Fair enough, seems like overkill for a "platform" bus though :)
> 
> You should see the box, really... ;-)

{sigh} why do hardware engineers ignore sane busses...

Anyway, if you all are going to maintain this, no objection from me, it
should go through the irq tree.

thanks,

greg k-h