linux-kernel - Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9Iy9EDh2gZgth+R@kroah.com>
Date:   Thu, 10 Dec 2020 15:38:44 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        syzbot <syzkaller@...glegroups.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation

On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote:
> On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume
> > IP header is already pulled.
> >
> > geneve does not ensure this yet.
> >
> > Fixing this generically in IP_ECN_decapsulate() and
> > IP6_ECN_decapsulate() is not possible, since callers
> > pass a pointer that might be freed by pskb_may_pull()
> >
> > syzbot reported :
> >
> 
> Note that we had to revert this patch, so you can either scratp this
> backport, or make sure to backport the revert.

I'll drop it thanks.  Odd I lost the upstream git id on this patch, let
me check what went wrong...

greg k-h