linux-kernel - Re: [PATCH 5.4 21/54] s390/pci: fix CPU address in MSI for directed IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Dec 2020 17:46:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Niklas Schnelle <schnelle@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        stable@...r.kernel.org, Alexander Gordeev <agordeev@...ux.ibm.com>,
        Halil Pasic <pasic@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>
Subject: Re: [PATCH 5.4 21/54] s390/pci: fix CPU address in MSI for directed
 IRQ

On Thu, Dec 10, 2020 at 05:34:08PM +0100, Niklas Schnelle wrote:
> Hi Greg,
> 
> sorry to bother you but I missed that the smp_cpu_get_cpu_address()
> address used here was only added with the
> commit 42d211a1ae3b77 ("s390/cpuinfo: show processor physical address")
> which landed in v5.7-rc1. This would therefore break if ever called
> (luckily it would not be called on any shipped hardware) and
> also causes a missing declaration warning as reported by
> Naresh Kamboju thanks!
> Since this is as of now just a spec fix, as on all known hardware
> the Linux CPU Id always matches the CPU Address, I would
> recommend to simply revert the commit.

Ok, will go drop it now, thanks.

greg k-h