linux-kernel - Re: [PATCH 1/2] rcu-tasks: move RCU-tasks initialization out of core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210173214.GU2657@paulmck-ThinkPad-P72>
Date:   Thu, 10 Dec 2020 09:32:14 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Daniel Axtens <dja@...ens.net>
Cc:     Uladzislau Rezki <urezki@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        LKML <linux-kernel@...r.kernel.org>, RCU <rcu@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        Neeraj Upadhyay <neeraju@...eaurora.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Theodore Y . Ts'o" <tytso@....edu>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>
Subject: Re: [PATCH 1/2] rcu-tasks: move RCU-tasks initialization out of
 core_initcall()

On Fri, Dec 11, 2020 at 12:39:21AM +1100, Daniel Axtens wrote:
> Hi Vlad,
> 
> >> Initialize the RCU-tasks earlier, before *_initcall() callbacks are
> >> invoked. Do it after the workqueue subsytem is up and running. That
> >> gives us a possibility to make use of synchronize_rcu_tasks*() wait
> >> API in early_initcall() callbacks.
> >> 
> >> Fixes: 36dadef23fcc ("kprobes: Init kprobes in early_initcall")
> >> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> 
> Tested-by: Daniel Axtens <dja@...ens.net>

I will apply on the next rebase, thank you!

							Thanx, Paul

> >> ---
> >>  include/linux/rcupdate.h |  6 ++++++
> >>  init/main.c              |  1 +
> >>  kernel/rcu/tasks.h       | 26 ++++++++++++++++++++++----
> >>  3 files changed, 29 insertions(+), 4 deletions(-)
> >> 
> > I still don't have a powerPC hw so far, even though i have sent a request
> > to the osuosl.org. It would be appreciated if Michael or Daniel could run
> > and verify it.
> 
> Sorry it's taken me so long to get to this. Your patch fixes things for
> me. Thanks!
> 
> BTW, I'm happy to see you taking on the challenge of RCU after your good
> work on vmalloc - all the best with it!
> 
> Kind regards,
> Daniel
> 
> >
> > Thank you in advance!
> >
> > --
> > Vlad Rezki