lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 09:43:48 -0800 From: Guenter Roeck <linux@...ck-us.net> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, Kyle Tso <kyletso@...gle.com>, Badhri Jagan Sridharan <badhri@...gle.com>, Will McVicker <willmcvicker@...gle.com> Subject: Re: [PATCH 3/5] USB: typec: tcpm: Fix PR_SWAP error handling On Thu, Dec 10, 2020 at 05:05:19PM +0100, Greg Kroah-Hartman wrote: > From: Kyle Tso <kyletso@...gle.com> > > PD rev3.0 8.3.3.16.3.6 PE_PRS_SRC_SNK_Wait_Source_on State > The Policy Enging Shall transition to the ErrorRecovery state when the > PSSourceOnTimer times out ... > > Cc: Guenter Roeck <linux@...ck-us.net> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > Cc: Badhri Jagan Sridharan <badhri@...gle.com> > Signed-off-by: Kyle Tso <kyletso@...gle.com> > Signed-off-by: Will McVicker <willmcvicker@...gle.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Reviewed-by: Guenter Roeck <linux@...ck-us.net> > --- > drivers/usb/typec/tcpm/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 0efda59bb104..d51c45961893 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -3728,7 +3728,7 @@ static void run_state_machine(struct tcpm_port *port) > tcpm_set_state(port, ERROR_RECOVERY, 0); > break; > } > - tcpm_set_state_cond(port, SNK_UNATTACHED, PD_T_PS_SOURCE_ON); > + tcpm_set_state(port, ERROR_RECOVERY, PD_T_PS_SOURCE_ON); > break; > case PR_SWAP_SRC_SNK_SINK_ON: > /* Set the vbus disconnect threshold for implicit contract */ > -- > 2.29.2 >
Powered by blists - more mailing lists