linux-kernel - Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201209183623.b26e90de3d0aa92a72010ff0@linux-foundation.org>
Date:   Wed, 9 Dec 2020 18:36:23 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Anton Altaparmakov <anton@...era.com>
Cc:     "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Zheng Zengkai <zhengzengkai@...wei.com>
Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable
 'log_page_mask'

On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov <anton@...era.com> wrote:

> Can you please apply this?
>
> ...
>
> > --- a/fs/ntfs/logfile.c
> > +++ b/fs/ntfs/logfile.c
> > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp)
> > 	 * optimize log_page_size and log_page_bits into constants.
> > 	 */
> > 	log_page_bits = ntfs_ffs(log_page_size) - 1;
> > -	size &= ~(s64)(log_page_size - 1);
> > +	size &= ~(s64)(log_page_mask);
> > 	/*
> > 	 * Ensure the log file is big enough to store at least the two restart
> > 	 * pages and the minimum number of log record pages.

https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/
addressed this?