linux-kernel - Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210184930.GF26529@zn.tnic>
Date:   Thu, 10 Dec 2020 19:49:30 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Chris Chiu <chiu@...lessos.org>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        peterz@...radead.org, luto@...nel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, linux@...lessos.org,
        Dan Nicholson <nicholson@...lessos.org>,
        Jian-Hong Pan <jhp@...lessos.org>
Subject: Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot
 quirk

On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> From: Dan Nicholson <nicholson@...lessos.org>
> 
> The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> reboot.

Is that what the "hard disk crash" in the comment below, refers to?

> It works without problem after adding the parameter
> reboot=bios.
> 
> Signed-off-by: Dan Nicholson <nicholson@...lessos.org>
> Signed-off-by: Chris Chiu <chiu@...lessos.org>
> Signed-off-by: Jian-Hong Pan <jhp@...lessos.org>

What's Jian's S-o-b tag supposed to mean?

> ---
> 
> v2:
>   - fix typo in the commit message.
> 
>  arch/x86/kernel/reboot.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index db115943e8bd..a03344616cd9 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = {
>  		},
>  	},
>  
> +	/* GIGABYTE */
> +	{	/* Workaround hard disk crash on ACPI reboot */
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette