linux-kernel - Re: [PATCH v4 1/4] pwm: pca9685: Switch to atomic API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201210203926.ouzrq3ff5k6zhlvt@pengutronix.de>
Date:   Thu, 10 Dec 2020 21:39:26 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Sven Van Asbroeck <thesven73@...il.com>,
        Clemens Gruber <clemens.gruber@...ruber.com>,
        linux-pwm@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        David Jander <david@...tonic.nl>
Subject: Re: [PATCH v4 1/4] pwm: pca9685: Switch to atomic API

Hello Thierry,

On Thu, Dec 10, 2020 at 06:10:45PM +0100, Thierry Reding wrote:
> Like I said, that's not what I was saying. I was merely saying that if
> there aren't any use-cases that current users rely on that would be
> broken by using this simpler implementation, then I'm okay with it, even
> if it's less flexible than a more complicated implementation. It should
> be possible to determine what the current users are by inspecting device
> trees present in the kernel. Anything outside the kernel isn't something
> we need to consider, as usual.

If "users in mainline" is the criteria that's a word.

So you agree we remove the following drivers?:

 - pwm-hibvt.c
   Last driver specific change in Feb 2019, no mainline user
 - pwm-sprd.c
   Last driver specific change in Aug 2019, no mainline user

Most PWMs are added to cpu.dtsi files with status = "disabled", I wonder
if it makes sense to check the machine.dts files if some of the PMWs are
completely unused. Do you consider status = "okay" a use that we have to
retain even if the node has no phandle?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)