linux-kernel - Re: [PATCH -next] mtd: rawnand: simplify the cs553x_write_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Dec 2020 22:19:08 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mtd: rawnand: simplify the
 cs553x_write_ctrl_byte()

Hi Yongjun,

Zheng Yongjun <zhengyongjun3@...wei.com> wrote on Wed, 9 Dec 2020
17:31:03 +0800:

> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/mtd/nand/raw/cs553x_nand.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/cs553x_nand.c b/drivers/mtd/nand/raw/cs553x_nand.c
> index 282203debd0c..a616aaa2e3dc 100644
> --- a/drivers/mtd/nand/raw/cs553x_nand.c
> +++ b/drivers/mtd/nand/raw/cs553x_nand.c
> @@ -105,17 +105,12 @@ static int cs553x_write_ctrl_byte(struct cs553x_nand_controller *cs553x,
>  				  u32 ctl, u8 data)
>  {
>  	u8 status;
> -	int ret;
>  
>  	writeb(ctl, cs553x->mmio + MM_NAND_CTL);
>  	writeb(data, cs553x->mmio + MM_NAND_IO);
> -	ret = readb_poll_timeout_atomic(cs553x->mmio + MM_NAND_STS, status,
> -					!(status & CS_NAND_CTLR_BUSY), 1,
> -					100000);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return readb_poll_timeout_atomic(cs553x->mmio + MM_NAND_STS, status,
> +					 !(status & CS_NAND_CTLR_BUSY), 1,
> +					 100000);
>  }
>  
>  static void cs553x_data_in(struct cs553x_nand_controller *cs553x, void *buf,

Sorry but this brings no value and I kind of personally dislike commits
darkening git blames for almost no reason, so if you don't mind I would
like to avoid such change.

Thanks,
Miquèl