linux-kernel - Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91b4b2f3591e6e8ce2d61daae31f2218d1a12b9e.camel@perches.com>
Date:   Thu, 10 Dec 2020 14:20:12 -0800
From:   Joe Perches <joe@...ches.com>
To:     Nicolai Fischer <nicolai.fischer@....de>,
        linux-kernel@...r.kernel.org
Cc:     apw@...onical.com, johannes.czekay@....de,
        linux-kernel@...cs.fau.de
Subject: Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing

On Wed, 2020-12-09 at 15:24 +0100, Nicolai Fischer wrote: 
> We understand that checkpatch may not be the ideal place for all of these checks.

So please work on an ideal thing.

> However the current implementation has some problems we would like to fix.
> Would you be interested in a patch series addressing just the check for the number of lines?
> Specifically:
> 1)
> > 
> > > 
> > > I believe all the '---help---' lines have been converted to just 'help'
> > > so the '(?:---)?' bits here could be removed.
> > 
> > Yes.
> > 
> 2) add string, hex and int types to the $is_start regex

sure

> 3) improve the help message to include the number of present and expected lines

no.  The concept of a required paragraph is still dubious.

> 4) Warn if help text is not followed by a blank line or endif

How often is it now not followed by a blank line or endif?