linux-kernel - Re: [linux-safety] [PATCH] kernel: trace: Remove deadstore in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMzTpOT3MJLkmjR_Hpak8K5a7GQ-vTtNp0GbNarD6NG1FA@mail.gmail.com>
Date:   Thu, 10 Dec 2020 06:47:13 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Milan Lakhani <milan.lakhani@...ethink.co.uk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-safety@...ts.elisa.tech
Subject: Re: [linux-safety] [PATCH] kernel: trace: Remove deadstore in trace_uprobe.c

On Wed, Dec 9, 2020 at 2:17 PM Milan Lakhani
<milan.lakhani@...ethink.co.uk> wrote:
>
> In trace_uprobe.c, trace_uprobe_create assigns ret to 0 but then never
> uses this value.
>

Milan, the patch makes sense, but I fear you did not run
./scripts/get_maintainers.pl because you did not include any specific
maintainer as recipient.

The patch subject could be: remove unneeded initialization (instead of
the very generic "dead store" term).

It is also interesting to see who added this initialization; was it
unneeded since the existence of this function, did it become obsolete
at some point in time due to refactoring?

Run ./scripts/get_maintainers.pl  and please CC: me; then you will get
your Reviewed-by: tag.

Lukas

> Signed-off-by: Milan Lakhani <milan.lakhani@...ethink.co.uk>
> ---
>  kernel/trace/trace_uprobe.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 3cf7128..c7c7070 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -541,7 +541,6 @@ static int trace_uprobe_create(int argc, const char **argv)
>         bool is_return = false;
>         int i, ret;
>
> -       ret = 0;
>         ref_ctr_offset = 0;
>
>         switch (argv[0][0]) {
> --
> 2.7.4
>