linux-kernel - Re: [PATCH v8 07/12] mm/hugetlb: Set the PageHWPoison to the raw error page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtUrmkm7N5r+vBjhiKNFksNG+eTKvTQL9FLcnj_3JHm5mA@mail.gmail.com>
Date:   Thu, 10 Dec 2020 19:11:19 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Jonathan Corbet <corbet@....net>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Thomas Gleixner <tglx@...utronix.de>, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com,
        dave.hansen@...ux.intel.com, luto@...nel.org,
        Peter Zijlstra <peterz@...radead.org>, viro@...iv.linux.org.uk,
        Andrew Morton <akpm@...ux-foundation.org>, paulmck@...nel.org,
        mchehab+huawei@...nel.org, pawan.kumar.gupta@...ux.intel.com,
        Randy Dunlap <rdunlap@...radead.org>, oneukum@...e.com,
        anshuman.khandual@....com, jroedel@...e.de,
        Mina Almasry <almasrymina@...gle.com>,
        David Rientjes <rientjes@...gle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Oscar Salvador <osalvador@...e.de>,
        Michal Hocko <mhocko@...e.com>,
        "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>,
        David Hildenbrand <david@...hat.com>
Cc:     Xiongchun duan <duanxiongchun@...edance.com>,
        linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v8 07/12] mm/hugetlb: Set the PageHWPoison to the raw
 error page

On Thu, Dec 10, 2020 at 11:58 AM Muchun Song <songmuchun@...edance.com> wrote:
>
> Because we reuse the first tail vmemmap page frame and remap it
> with read-only, we cannot set the PageHWPosion on a tail page.
> So we can use the head[4].mapping to record the real error page
                              ^^^
                             private

A typo. Will update the next version. Thanks.

> index and set the raw error page PageHWPoison later.
>
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  mm/hugetlb.c | 52 ++++++++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 44 insertions(+), 8 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 542e6cb81321..06157df08d8e 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1347,6 +1347,47 @@ static inline void __update_and_free_page(struct hstate *h, struct page *page)
>                 schedule_work(&hpage_update_work);
>  }
>
> +static inline void subpage_hwpoison_deliver(struct hstate *h, struct page *head)
> +{
> +       struct page *page = head;
> +
> +       if (!free_vmemmap_pages_per_hpage(h))
> +               return;
> +
> +       if (PageHWPoison(head))
> +               page = head + page_private(head + 4);
> +
> +       /*
> +        * Move PageHWPoison flag from head page to the raw error page,
> +        * which makes any subpages rather than the error page reusable.
> +        */
> +       if (page != head) {
> +               SetPageHWPoison(page);
> +               ClearPageHWPoison(head);
> +       }
> +}
> +
> +static inline void set_subpage_hwpoison(struct hstate *h, struct page *head,
> +                                       struct page *page)
> +{
> +       if (!PageHWPoison(head))
> +               return;
> +
> +       if (free_vmemmap_pages_per_hpage(h)) {
> +               set_page_private(head + 4, page - head);
> +               return;
> +       }
> +
> +       /*
> +        * Move PageHWPoison flag from head page to the raw error page,
> +        * which makes any subpages rather than the error page reusable.
> +        */
> +       if (page != head) {
> +               SetPageHWPoison(page);
> +               ClearPageHWPoison(head);
> +       }
> +}
> +
>  static void update_and_free_page(struct hstate *h, struct page *page)
>  {
>         if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported())
> @@ -1363,6 +1404,7 @@ static void __free_hugepage(struct hstate *h, struct page *page)
>         int i;
>
>         alloc_huge_page_vmemmap(h, page);
> +       subpage_hwpoison_deliver(h, page);
>
>         for (i = 0; i < pages_per_huge_page(h); i++) {
>                 page[i].flags &= ~(1 << PG_locked | 1 << PG_error |
> @@ -1840,14 +1882,8 @@ int dissolve_free_huge_page(struct page *page)
>                 int nid = page_to_nid(head);
>                 if (h->free_huge_pages - h->resv_huge_pages == 0)
>                         goto out;
> -               /*
> -                * Move PageHWPoison flag from head page to the raw error page,
> -                * which makes any subpages rather than the error page reusable.
> -                */
> -               if (PageHWPoison(head) && page != head) {
> -                       SetPageHWPoison(page);
> -                       ClearPageHWPoison(head);
> -               }
> +
> +               set_subpage_hwpoison(h, head, page);
>                 list_del(&head->lru);
>                 h->free_huge_pages--;
>                 h->free_huge_pages_node[nid]--;
> --
> 2.11.0
>


-- 
Yours,
Muchun