linux-kernel - Re: [PATCH -next] platform: surface: fix non-PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3705938f-6f82-88ef-455b-e0f7459989e3@gmail.com>
Date:   Fri, 11 Dec 2020 21:23:21 +0100
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Hans de Goede <hdegoede@...hat.com>,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings

On 12/11/20 8:03 PM, Randy Dunlap wrote:
> Fix build warnings when CONFIG_PM_SLEEP is not enabled and these
> functions are not used:
> 
> ../drivers/platform/surface/surface_gpe.c:189:12: warning: ‘surface_gpe_resume’ defined but not used [-Wunused-function]
>   static int surface_gpe_resume(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~
> ../drivers/platform/surface/surface_gpe.c:184:12: warning: ‘surface_gpe_suspend’ defined but not used [-Wunused-function]
>   static int surface_gpe_suspend(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~~
> 
> Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS Surface device")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Maximilian Luz <luzmaximilian@...il.com>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: platform-driver-x86@...r.kernel.org
> ---
>   drivers/platform/surface/surface_gpe.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> --- linux-next-20201210.orig/drivers/platform/surface/surface_gpe.c
> +++ linux-next-20201210/drivers/platform/surface/surface_gpe.c
> @@ -181,6 +181,7 @@ static int surface_lid_enable_wakeup(str
>   	return 0;
>   }
>   
> +#ifdef CONFIG_PM_SLEEP
>   static int surface_gpe_suspend(struct device *dev)
>   {
>   	return surface_lid_enable_wakeup(dev, true);
> @@ -190,6 +191,7 @@ static int surface_gpe_resume(struct dev
>   {
>   	return surface_lid_enable_wakeup(dev, false);
>   }
> +#endif
>   
>   static SIMPLE_DEV_PM_OPS(surface_gpe_pm, surface_gpe_suspend, surface_gpe_resume);
>   
> 

Right, thanks.

I assume this covers all instances of this warning in platform/surface?
Otherwise, a "platform: surface: gpe: ..." subject would make more sense.

As for the rest:

Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>

Regards,
Max