linux-kernel - Re: [PATCH] gpiolib: irq hooks: fix recursion in gpiochip_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaUdF_4RDWAw=8B_HL0e13KmwU34oYDGc-sFctD_5VAjQ@mail.gmail.com>
Date:   Sat, 12 Dec 2020 00:26:31 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Maulik Shah <mkshah@...eaurora.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: irq hooks: fix recursion in gpiochip_irq_unmask

On Thu, Dec 10, 2020 at 8:06 AM Nikita Shubin <nikita.shubin@...uefel.me> wrote:

> irqchip shared with multiple gpiochips, leads to recursive call of
> gpiochip_irq_mask/gpiochip_irq_unmask which was assigned to
> rqchip->irq_mask/irqchip->irq_unmask, these happens becouse of
> only irqchip->irq_enable == gpiochip_irq_enable is checked.
>
> Let's add an additional check to make sure shared irqchip is detected
> even if irqchip->irq_enable wasn't defined.
>
> Fixes: a8173820f441 ("gpio: gpiolib: Allow GPIO IRQs to lazy disable")
> Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>

Good catch!
Patch applied.

Yours,
Linus Walleij