linux-kernel - Re: [PATCH 1/2] Input: elan_i2c - Add new trackpoint report type 0x5F.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Dec 2020 19:04:58 -0800
From:   'Dmitry Torokhov' <dmitry.torokhov@...il.com>
To:     jingle <jingle.wu@....com.tw>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        phoenix@....com.tw, josh.chen@....com.tw, dave.wang@....com.tw
Subject: Re: [PATCH 1/2] Input: elan_i2c - Add new trackpoint report type
 0x5F.

Hi Jingle,

On Fri, Dec 11, 2020 at 10:38:22AM +0800, jingle wrote:
> HI Dmitry:

Please do not top post on the kernel mailing lists.

> 
> I would prefer if we validated report length versus the packet type before
> accepting it.
> 
> -> If the tracking point report is 0x5F, the report length is 7, but the
> touchpad report length is 32.
> -> So, report length will be different with this module.

Right, but we could check the report type when we receive the data and
refuse it if length does not match what is expected for the report type
received. This can happen before we pass the data on to the
elan_i2c_core.

Thanks.

-- 
Dmitry