linux-kernel - Re: [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 09:59:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings

On 10-12-20, 12:31, Stephen Boyd wrote:
> Quoting Vinod Koul (2020-12-09 22:11:59)
> > On 09-12-20, 22:01, Rob Herring wrote:
> > > On Tue, Dec 08, 2020 at 12:17:00PM +0530, Vinod Koul wrote:
> > 
> > > > +required:
> > > > +  - compatible
> > > > +  - clocks
> > > > +  - clock-names
> > > > +  - reg
> > > > +  - '#clock-cells'
> > > > +  - '#reset-cells'
> > > 
> > > You may or may not have power domains?
> > 
> > I have not added them in the driver yet, so I dont think it made sense
> > to add them when they are not present. For basic stuff it is not
> > required but eventually yes, so I plan to update binding and driver at
> > that time
> > 
> 
> They should still be required in the binding though if the hardware has
> power domains. It's not like the hardware doesn't have power domains
> already or can gain that ability after the fact. The driver should deal
> with it when it is ready.

Yeah that is a valid argument, I will add and send updated revision

Thanks
-- 
~Vinod