linux-kernel - RE: [PATCH] ath10k: Remove voltage regulator votes during wifi disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000301d6cf80$e0c44150$a24cc3f0$@codeaurora.org>
Date:   Fri, 11 Dec 2020 11:15:42 +0530
From:   "Rakesh Pillai" <pillair@...eaurora.org>
To:     "'Brian Norris'" <briannorris@...omium.org>
Cc:     "'ath10k'" <ath10k@...ts.infradead.org>,
        "'linux-wireless'" <linux-wireless@...r.kernel.org>,
        "'Linux Kernel'" <linux-kernel@...r.kernel.org>,
        "'Doug Anderson'" <dianders@...omium.org>, <kuabhs@...omium.org>,
        "'Youghandhar Chintala'" <youghand@...eaurora.org>
Subject: RE: [PATCH] ath10k: Remove voltage regulator votes during wifi disable



> -----Original Message-----
> From: Brian Norris <briannorris@...omium.org>
> Sent: Thursday, December 10, 2020 11:44 PM
> To: Rakesh Pillai <pillair@...eaurora.org>
> Cc: ath10k <ath10k@...ts.infradead.org>; linux-wireless <linux-
> wireless@...r.kernel.org>; Linux Kernel <linux-kernel@...r.kernel.org>;
> Doug Anderson <dianders@...omium.org>; kuabhs@...omium.org;
> Youghandhar Chintala <youghand@...eaurora.org>
> Subject: Re: [PATCH] ath10k: Remove voltage regulator votes during wifi
> disable
> 
> On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai <pillair@...eaurora.org>
> wrote:
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct
> ath10k *ar,
> >         ret = ath10k_snoc_init_pipes(ar);
> >         if (ret) {
> >                 ath10k_err(ar, "failed to initialize CE: %d\n", ret);
> > -               goto err_wlan_enable;
> > +               goto err_free_rri;
> >         }
> >
> >         return 0;
> >
> > -err_wlan_enable:
> > +err_free_rri:
> > +       ath10k_ce_free_rri(ar);
> 
> This change in the error path seems to be an unrelated (but correct)
> fix. It deserves its own patch, I think.

Sure Brian. I will post this error handling fix as a separate patch, and also post a v2 for this patchset.