linux-kernel - Re: [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 11:40:38 +0530
From:   Aswath Govindraju <a-govindraju@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Vignesh Raghavendra <vigneshr@...com>,
        Sekhar Nori <nsekhar@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Roger Quadros <rogerq@...com>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: usb: Add new compatible string for AM64
 SoC

Hi Rob,

On 11/12/20 9:07 am, Rob Herring wrote:
> On Thu, Dec 10, 2020 at 12:24:50PM +0530, Aswath Govindraju wrote:
>> Add compatible string in j721e-usb binding file as the same USB subsystem
>> is present in AM64.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
>> Acked-by: Roger Quadros <rogerq@...com>
>> ---
>>
>> Changes since v2:
>> - added changes done over the versions
>>
>> Changes since v1:
>> - replaced the '\t' at the beginning of the lines with spaces as it was
>>   causing the dt_binding_check to fail
>>
>>
>>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> index 388245b91a55..453587f6d304 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> @@ -11,8 +11,11 @@ maintainers:
>>  
>>  properties:
>>    compatible:
>> -    items:
>> -      - const: ti,j721e-usb
>> +    anyOf:
>> +      - items:
>> +          - const: ti,j721e-usb
>> +      - items:
>> +          - const: ti,am64-usb
> 
> compatible:
>   enum:
>     - ti,j721e-usb
>     - ti,am64-usb
> 

Thank you for the comments.

I have sent a respin for this patch making the above changes.

May I please know a case where anyOf would be used rather than enum
because after reading the documentation[1], I thought that using enum
meant that only one of the listed strings in enum can be used as
compatible strings in a given node.

[1]https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml

Thanks,
Aswath

>>  
>>    reg:
>>      description: module registers
>> -- 
>> 2.17.1
>>