linux-kernel - Re: [PATCH] init: fix msleep() is not accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X9MfoL/GtGJjVj3a@light.dominikbrodowski.net>
Date:   Fri, 11 Dec 2020 08:28:32 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Yejune Deng <yejune.deng@...il.com>
Cc:     axboe@...nel.dk, hare@...e.de, jack@...e.cz,
        gregkh@...uxfoundation.org, tj@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init:  fix msleep() is not accurate

Am Fri, Dec 11, 2020 at 11:24:12AM +0800 schrieb Yejune Deng:
> See Documentation/timers/timers-howto.rst, msleep() is not
> for (1ms - 20ms),use usleep_range() instead.

While technically correct, this branch is only taken if the "rootwait"
kernel parameter is passed -- and as the kernel is looping here, it does not
really hurt if the msleep(5) takes a bit longer than advertised.

Thanks,
	Dominik