lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201211090711.GH1594451@kuha.fi.intel.com>
Date:   Fri, 11 Dec 2020 11:07:11 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     linux@...ck-us.net, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] usb: typec: tcpm: convert comma to semicolon

On Fri, Dec 11, 2020 at 04:55:53PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index a6fae1f86505..4451507d600c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5024,14 +5024,14 @@ static int devm_tcpm_psy_register(struct tcpm_port *port)
>  	snprintf(psy_name, psy_name_len, "%s%s", tcpm_psy_name_prefix,
>  		 port_dev_name);
>  	port->psy_desc.name = psy_name;
> -	port->psy_desc.type = POWER_SUPPLY_TYPE_USB,
> +	port->psy_desc.type = POWER_SUPPLY_TYPE_USB;
>  	port->psy_desc.usb_types = tcpm_psy_usb_types;
>  	port->psy_desc.num_usb_types = ARRAY_SIZE(tcpm_psy_usb_types);
> -	port->psy_desc.properties = tcpm_psy_props,
> -	port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props),
> -	port->psy_desc.get_property = tcpm_psy_get_prop,
> -	port->psy_desc.set_property = tcpm_psy_set_prop,
> -	port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable,
> +	port->psy_desc.properties = tcpm_psy_props;
> +	port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props);
> +	port->psy_desc.get_property = tcpm_psy_get_prop;
> +	port->psy_desc.set_property = tcpm_psy_set_prop;
> +	port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable;
>  
>  	port->usb_type = POWER_SUPPLY_USB_TYPE_C;
>  
> -- 
> 2.22.0

thanks,

-- 
heikki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ