linux-kernel - Re: [patch 8/8] ntp: Consolidate the RTC update implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877dpoitm6.fsf@nanos.tec.linutronix.de>
Date:   Fri, 11 Dec 2020 10:23:29 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        John Stultz <john.stultz@...aro.org>,
        Prarit Bhargava <prarit@...hat.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch 8/8] ntp: Consolidate the RTC update implementation

On Mon, Dec 07 2020 at 17:05, Jason Gunthorpe wrote:
> On Sun, Dec 06, 2020 at 10:46:21PM +0100, Thomas Gleixner wrote:
>>  static void sync_hw_clock(struct work_struct *work)
>>  {
>> +	static unsigned long offset_nsec = NSEC_PER_SEC / 2;
>
> A comment here explaining this is the default: because the platform is
> assumed to use CMOS, and by the way, this whole thing is obsolete
> don't use it, seems appropriate..

Will add something like that.

> The time split is clearer if you think of it from a bus/datasheet
> perspective, less clear if you try to measure the system directly, eg
> from an alarm. But, I think this  has a better chance of some rtclib
> driver authors to fill in the datasheet value at least.

That's the hope. You know hope dies last...

Thanks,

        tglx