linux-kernel - Re: [PATCH -next] char/tpm: simplify the return expression of tpm_tis_synquacer_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 12:53:34 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     peterhuewe@....de, jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] char/tpm: simplify the return expression of
 tpm_tis_synquacer_module_init()

On Thu, Dec 10, 2020 at 09:55:15PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

I don't see how this would be meaningful change as the existing
code is according to the coding style.

> ---
>  drivers/char/tpm/tpm_tis_synquacer.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
> index e47bdd272704..3b4ae2f23f09 100644
> --- a/drivers/char/tpm/tpm_tis_synquacer.c
> +++ b/drivers/char/tpm/tpm_tis_synquacer.c
> @@ -188,13 +188,8 @@ static struct platform_driver tis_synquacer_drv = {
>  
>  static int __init tpm_tis_synquacer_module_init(void)
>  {
> -	int rc;
>  
> -	rc = platform_driver_register(&tis_synquacer_drv);
> -	if (rc)
> -		return rc;
> -
> -	return 0;
> +	return platform_driver_register(&tis_synquacer_drv);
>  }
>  
>  static void __exit tpm_tis_synquacer_module_exit(void)
> -- 
> 2.22.0
> 
> 

/Jarkko