linux-kernel - Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211114515.GF1781038@piout.net>
Date:   Fri, 11 Dec 2020 12:45:15 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non
 AT91 SoCs

Hello,

On 11/12/2020 10:31:43+0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> 	" AT91: Could not find identification node"
> 
> Fix the same by filtering with allowed AT91 SoC list.
> 
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@...rochip.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>  drivers/soc/atmel/soc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index c4472b68b7c2..ba9fc07cd91c 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
>  	return soc_dev;
>  }
>  
> +static const struct of_device_id at91_soc_allowed_list[] __initconst = {
> +	{ .compatible = "atmel,at91rm9200", },
> +	{ .compatible = "atmel,at91sam9260", },
> +	{ .compatible = "atmel,sama5d2", },

This is a very small subset of the supported SoCs. a proper list would
be:

atmel,at91rm9200
atmel,at91sam9
atmel,sama5
atmel,samv7


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com