linux-kernel - Re: [PATCH] leds: led-core: Get rid of enum led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211135628.1fe1af79@nic.cz>
Date:   Fri, 11 Dec 2020 13:56:28 +0100
From:   Marek Behun <marek.behun@....cz>
To:     Abanoub Sameh <abanoubsameh8@...il.com>
Cc:     pavel@....cz, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Abanoub Sameh <abanoubsameh@...tonmail.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] leds: led-core: Get rid of enum led_brightness

On Fri, 11 Dec 2020 03:48:40 +0200
Abanoub Sameh <abanoubsameh8@...il.com> wrote:

> This gets rid of enum led_brightness in the main led files,
> because it is deprecated, and an int can be used instead,
> or maybe even a uint8_t since it only goes up to 255.
> Next we can also patch the other files to get rid of it completely.

1. unsigned int should be used IMO
  - using int may force all implementers to check for negative value
    and return -EINVAL, which is stupid
  - some LED controllers may offer more than 8bit brightness value, so
    no uint8_t
2. I think we should remove all usages with one commit

Marek