linux-kernel - Re: [PATCH] irqchip/ti-sci-intr: Fix freeing of irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <160769813659.482133.15271657798818561633.b4-ty@kernel.org>
Date:   Fri, 11 Dec 2020 15:01:38 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     shawnguo@...nel.org, linux@...musvillemoes.dk, leoyang.li@....com,
        mark.rutland@....com, zhiqiang.hou@....com,
        Biwen Li <biwen.li@....nxp.com>, robh+dt@...nel.org,
        tglx@...utronix.de, Lokesh Vutla <lokeshvutla@...com>
Cc:     xiaobo.xie@....com, Hou Zhiqiang <Zhiqiang.Hou@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Biwen Li <biwen.li@....com>, linux-kernel@...r.kernel.org,
        jiafei.pan@....com, Sekhar Nori <nsekhar@...com>,
        Nishanth Menon <nm@...com>
Subject: Re: [PATCH] irqchip/ti-sci-intr: Fix freeing of irqs

On Mon, 2 Nov 2020 17:36:31 +0530, Lokesh Vutla wrote:
> ti_sci_intr_irq_domain_free() assumes that out_irq of intr is stored in
> data->chip_data and uses it for calling ti_sci irq_free() and then
> mark the out_irq as available resource. But ti_sci_intr_irq_domain_alloc()
> is storing p_hwirq(parent's hardware irq) which is translated from out_irq.
> This is causing resource leakage and eventually out_irq resources might
> be exhausted. Fix ti_sci_intr_irq_domain_alloc() by storing the out_irq
> in data->chip_data.

Applied to irq/irqchip-next, thanks!

[1/1] irqchip/ti-sci-intr: Fix freeing of irqs
      commit: fc6c7cd3878641fd43189f15697e7ad0871f5c1a

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.