linux-kernel - Re: [PATCH] i2c: sprd: use a specific timeout to avoid system hang up issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 23:42:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chunyan Zhang <zhang.lyra@...il.com>,
        Wolfram Sang <wsa-dev@...g-engineering.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Orson Zhai <orsonzhai@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chunyan Zhang <zhang.lyra@...il.com>,
        Linhua Xu <linhua.xu@...soc.com>
Subject: Re: [PATCH] i2c: sprd: use a specific timeout to avoid system hang
 up issue

Hi Chunyan,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v5.10-rc7 next-20201211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chunyan-Zhang/i2c-sprd-use-a-specific-timeout-to-avoid-system-hang-up-issue/20201211-182817
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: mips-randconfig-r035-20201209 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/725c61cfaa18f63c1fbc7f4a25a04a72c4fbda48
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chunyan-Zhang/i2c-sprd-use-a-specific-timeout-to-avoid-system-hang-up-issue/20201211-182817
        git checkout 725c61cfaa18f63c1fbc7f4a25a04a72c4fbda48
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-sprd.c: In function 'sprd_i2c_handle_msg':
>> drivers/i2c/busses/i2c-sprd.c:249:43: error: 'I2C_XFER_TIMEOUT' undeclared (first use in this function); did you mean 'IC2_XFER_TIMEOUT'?
     249 |  unsigned long timeout = msecs_to_jiffies(I2C_XFER_TIMEOUT);
         |                                           ^~~~~~~~~~~~~~~~
         |                                           IC2_XFER_TIMEOUT
   drivers/i2c/busses/i2c-sprd.c:249:43: note: each undeclared identifier is reported only once for each function it appears in

vim +249 drivers/i2c/busses/i2c-sprd.c

   244	
   245	static int sprd_i2c_handle_msg(struct i2c_adapter *i2c_adap,
   246				       struct i2c_msg *msg, bool is_last_msg)
   247	{
   248		struct sprd_i2c *i2c_dev = i2c_adap->algo_data;
 > 249		unsigned long timeout = msecs_to_jiffies(I2C_XFER_TIMEOUT);
   250	
   251		i2c_dev->msg = msg;
   252		i2c_dev->buf = msg->buf;
   253		i2c_dev->count = msg->len;
   254	
   255		reinit_completion(&i2c_dev->complete);
   256		sprd_i2c_reset_fifo(i2c_dev);
   257		sprd_i2c_set_devaddr(i2c_dev, msg);
   258		sprd_i2c_set_count(i2c_dev, msg->len);
   259	
   260		if (msg->flags & I2C_M_RD) {
   261			sprd_i2c_opt_mode(i2c_dev, 1);
   262			sprd_i2c_send_stop(i2c_dev, 1);
   263		} else {
   264			sprd_i2c_opt_mode(i2c_dev, 0);
   265			sprd_i2c_send_stop(i2c_dev, !!is_last_msg);
   266		}
   267	
   268		/*
   269		 * We should enable rx fifo full interrupt to get data when receiving
   270		 * full data.
   271		 */
   272		if (msg->flags & I2C_M_RD)
   273			sprd_i2c_set_fifo_full_int(i2c_dev, 1);
   274		else
   275			sprd_i2c_data_transfer(i2c_dev);
   276	
   277		sprd_i2c_opt_start(i2c_dev);
   278	
   279		timeout = wait_for_completion_timeout(&i2c_dev->complete, timeout);
   280		if (!timeout)
   281			return -EIO;
   282	
   283		return i2c_dev->err;
   284	}
   285	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (43344 bytes)