linux-kernel - Re: [PATCH v5 5/5] scsi: hisi_sas: Expose HW queues for v2 hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a30086c-8a23-2272-fac9-a66ca92ae2f8@huawei.com>
Date:   Fri, 11 Dec 2020 16:56:22 +0000
From:   John Garry <john.garry@...wei.com>
To:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>
CC:     <lenb@...nel.org>, <rjw@...ysocki.net>,
        <gregkh@...uxfoundation.org>, <tglx@...utronix.de>,
        <maz@...nel.org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-acpi@...r.kernel.org>, <dwagner@...e.de>
Subject: Re: [PATCH v5 5/5] scsi: hisi_sas: Expose HW queues for v2 hw

On 02/12/2020 10:36, John Garry wrote:
> As a performance enhancement, make the completion queue interrupts managed.
> 
> In addition, in commit bf0beec0607d ("blk-mq: drain I/O when all CPUs in a
> hctx are offline"), CPU hotplug for MQ devices using managed interrupts
> is made safe. So expose HW queues to blk-mq to take advantage of this.
> 
> Flag Scsi_host.host_tagset is also set to ensure that the HBA is not sent
> more commands than it can handle. However the driver still does not use
> request tag for IPTT as there are many HW bugs means that special rules
> apply for IPTT allocation.
> 

Hi Martin, James,

Is there some way in this patch can be merged for 5.11 via the SCSI 
tree? It has a dependency on the earlier patches in the series, now 
picked up via irqchip tree. I've seen multiple rounds of SCSI pull 
requests before, but not sure when we have that or if the tree is 
rebased for those.

Thanks,
John


> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   drivers/scsi/hisi_sas/hisi_sas.h       |  4 ++
>   drivers/scsi/hisi_sas/hisi_sas_main.c  | 11 +++++
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 66 +++++++++++++++++++++-----
>   3 files changed, 68 insertions(+), 13 deletions(-)
>