lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Dec 2020 20:12:07 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Marc Zyngier <maz@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Lee Jones <lee.jones@...aro.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, Helge Deller <deller@....de>, afzal mohammed <afzal.mohd.ma@...il.com>, linux-parisc@...r.kernel.org, Russell King <linux@...linux.org.uk>, Mark Rutland <mark.rutland@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Christian Borntraeger <borntraeger@...ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, linux-s390@...r.kernel.org, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>, Chris Wilson <chris@...is-wilson.co.uk>, Wambui Karuga <wambui.karugax@...il.com>, intel-gfx <intel-gfx@...ts.freedesktop.org>, dri-devel <dri-devel@...ts.freedesktop.org>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>, linux-ntb@...glegroups.com, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Michal Simek <michal.simek@...inx.com>, linux-pci <linux-pci@...r.kernel.org>, Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>, Hou Zhiqiang <Zhiqiang.Hou@....com>, Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev <netdev@...r.kernel.org>, "open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, Juergen Gross <jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>, xen-devel@...ts.xenproject.org Subject: Re: [patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc On Thu, Dec 10, 2020 at 9:57 PM Thomas Gleixner <tglx@...utronix.de> wrote: > > First of all drivers have absolutely no business to dig into the internals > of an irq descriptor. That's core code and subject to change. All of this > information is readily available to /proc/interrupts in a safe and race > free way. > > Remove the inspection code which is a blatant violation of subsystem > boundaries and racy against concurrent modifications of the interrupt > descriptor. > > Print the irq line instead so the information can be looked up in a sane > way in /proc/interrupts. ... > - seq_printf(s, "%3i: %6i %4i", > + seq_printf(s, "%3i: %6i %4i %4i\n", Seems different specifiers, I think the intention was something like seq_printf(s, "%3i: %4i %6i %4i\n", > line, > + line + irq_first, > num_interrupts[line], > num_wake_interrupts[line]); -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists