linux-kernel - Re: [PATCH v4] Serial: silabs si4455 serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Dec 2020 07:31:32 +0000
From:   József Horváth <info@...istro.hu>
To:     'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
        'Rob Herring' <robh+dt@...nel.org>,
        'Jiri Slaby' <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Serial: silabs si4455 serial driver

On Sat, Dec 12, 2020 at 07:09:46AM +0000, József Horváth wrote:
> This is a serial port driver for
>  Silicon Labs Si4455 Sub-GHz transciver.
> 
> The goal of this driver is to removing wires
>  between central(linux) device and remote serial devices/sensors,
>  but keeping the original user software.
>  It represents regular serial interface for the user space.
> 
> Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
> 
> Signed-off-by: József Horváth <info@...istro.hu>
> ---
>  .../staging/serial/silabs,si4455.yaml         |   95 ++
>  MAINTAINERS                                   |    6 +
>  drivers/tty/serial/Kconfig                    |    8 +
>  drivers/tty/serial/Makefile                   |    1 +
>  drivers/tty/serial/si4455.c                   | 1328 +++++++++++++++++
>  5 files changed, 1438 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml
>  create mode 100644 drivers/tty/serial/si4455.c
> 
> diff --git a/Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml b/Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml
> new file mode 100644
> index 000000000000..d3a8c07c6714
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#"

In this version I changed the $id to "http://.../staging/..." and removed $ref: "serial.yaml#".
The make dt_binding_check completes without any error or warning, but this is not a good solution.

My question is, how can I use $ref: "serial.yaml" dependency, while my schema is under staging?
	allOf:
  	  - $ref: "serial.yaml#"

The make dt_binding_check output, while the schema is in staging, and $ref: "serial.yaml" dependency in the schema:

	Unknown file referenced: [Errno 2] No such file or directory: '/home/administrator/.local/lib/python3.6/site-packages/dtschema/schemas/staging/serial/serial.yaml'
	xargs: dt-doc-validate: exited with status 255; aborting
	Documentation/devicetree/bindings/Makefile:59: recipe for target 'Documentation/devicetree/bindings/processed-schema-examples.json' failed
	make[1]: *** [Documentation/devicetree/bindings/processed-schema-examples.json] Error 124
	Makefile:1364: recipe for target 'dt_binding_check' failed
	make: *** [dt_binding_check] Error 2



> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Silicon Labs Si4455 device tree bindings
> +
> 
> 

Üdvözlettel / Best regards:
József Horváth