lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Dec 2020 04:14:26 +0300 From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: linux-kernel@...r.kernel.org Subject: [PATCH] driver core: platform: don't oops on unbound devices Platform code stopped checking if the device is bound to the actual platform driver, thus calling non-existing drv->shutdown(). Verify that _dev->driver is not NULL before calling remove/shutdown callbacks. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> Fixes: 9c30921fe799 ("driver core: platform: use bus_type functions") --- drivers/base/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 0358dc3ea3ad..93f44e69b472 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -1342,7 +1342,7 @@ static int platform_remove(struct device *_dev) struct platform_device *dev = to_platform_device(_dev); int ret = 0; - if (drv->remove) + if (_dev->driver && drv->remove) ret = drv->remove(dev); dev_pm_domain_detach(_dev, true); @@ -1354,7 +1354,7 @@ static void platform_shutdown(struct device *_dev) struct platform_driver *drv = to_platform_driver(_dev->driver); struct platform_device *dev = to_platform_device(_dev); - if (drv->shutdown) + if (_dev->driver && drv->shutdown) drv->shutdown(dev); } -- 2.29.2
Powered by blists - more mailing lists