[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 11 Dec 2020 19:04:13 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Chunyan Zhang <zhang.lyra@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>, linux-input@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang7@...il.com>,
Chunyan Zhang <chunyan.zhang@...soc.com>,
Nemo Han <nemo.han@...soc.com>
Subject: Re: [PATCH v2 1/3] input: sc27xx: Add support for sc2730 and sc2721
Hi Chunyan,
On Tue, Nov 17, 2020 at 11:49:47AM +0800, Chunyan Zhang wrote:
> @@ -78,8 +112,15 @@ static void sc27xx_vibra_close(struct input_dev *input)
> static int sc27xx_vibra_probe(struct platform_device *pdev)
> {
> struct vibra_info *info;
> + const struct sc27xx_vibra_data *data;
> int error;
>
> + data = of_device_get_match_data(&pdev->dev);
> + if (!data) {
> + dev_err(&pdev->dev, "no matching driver data found\n");
> + return -EINVAL;
> + }
This does not have to be OF-specific, so I changed it to
device_get_match_data() and applied, thank you.
--
Dmitry
Powered by blists - more mailing lists