linux-kernel - Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c661c10e-fa21-d3e5-9d94-6f8f2d89f1d0@infradead.org>
Date:   Sun, 13 Dec 2020 09:22:59 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     eli.billauer@...il.com, gregkh@...uxfoundation.org, arnd@...db.de
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant
 for USB)

On 12/13/20 9:05 AM, eli.billauer@...il.com wrote:
> diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig
> index 130dbdce858f..18fa99ec1029 100644
> --- a/drivers/char/xillybus/Kconfig
> +++ b/drivers/char/xillybus/Kconfig
> @@ -32,3 +32,14 @@ config XILLYBUS_OF
>  	  system, say M.
>  
>  endif # if XILLYBUS
> +

Hi Eli,

You don't want this new part inside the "if XILLYBUS" block above?
IOW, XILLYUSB does not need XILLYBUS?

> +config XILLYUSB
> +	tristate "XillyUSB: Xillybus generic FPGA interface for USB"
> +	depends on USB
> +	select CRC32
> +	help
> +	  XillyUSB is the Xillybus variant which uses USB for communicating
> +	  with the FPGA.
> +
> +	  Set to M if you want Xillybus to use USB for communicating with
> +	  the FPGA.

thanks.
-- 
~Randy