lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 13 Dec 2020 13:30:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        John Stultz <john.stultz@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v3 2/2] usb: dwc3: drd: Improve dwc3_get_extcon() style

On Sun, Dec 13, 2020 at 5:27 AM Sam Protsenko
<semen.protsenko@...aro.org> wrote:
>
> Commit c73b41955ee4 ("usb: dwc3: drd: Avoid error when extcon is

The previous change ("...

(because we don't know the actual commit id)

> missing") changed the code flow in dwc3_get_extcon() function, leading
> to unnecessary if-branch. This patch does housekeeping by reworking the
> code for obtaining extcon device from the "port" node. While at it, add

an extcon

> the  comment from mentioned code block, explaining how checking the port
> availability helps to avoid the misleading error.

...

> +       /*
> +        * Try to get extcon device from USB PHY controller's "port" node.

an extcon
the USB

> +        * Check if it has the "port" node first, to avoid printing the error
> +        * message from underlying code, as it's a valid case: extcon device
> +        * (and "port" node) may be missing in case of "usb-role-switch" or OTG
> +        * mode.
> +        */

To me it sounds like this should be in the previous patch.

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists