lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Dec 2020 10:05:36 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Markus Elfring <Markus.Elfring@....de> Cc: kernel-janitors@...r.kernel.org, linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Ludovic Desroches <ludovic.desroches@...rochip.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Ulf Hansson <ulf.hansson@...aro.org>, LKML <linux-kernel@...r.kernel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Colin Ian King <colin.king@...onical.com> Subject: Re: mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end() On Fri, Dec 11, 2020 at 10:08:54AM +0100, Markus Elfring wrote: > > This makes it hard to review any patches or follow discussion... > > You shared also special software development opinions about extra variable > initialisations occasionally, didn't you? I generally put everything at the top of the function... I don't have a well developed philosophy for when variables should be declared with a smaller scope. int ret; <-- this should always be function scope Probably the other people are right that making scopes shorter is more important when the function is very long. regards, dan carpenter
Powered by blists - more mailing lists