linux-kernel - Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214103704.bkgwh4bdelrtovgd@gilmour>
Date:   Mon, 14 Dec 2020 11:37:04 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Ondrej Jirman <megous@...ous.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT
 binding

On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
> 
> Add a new DT compatible for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 6db32fbf813f..73a6c8421172 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -700,6 +700,11 @@ properties:
>            - const: pine64,pinetab
>            - const: allwinner,sun50i-a64
>  
> +      - description: Pine64 PineTab with new LCD panel
> +        items:
> +          - const: pine64,pinetab-new-panel
> +          - const: allwinner,sun50i-a64
> +

We're on the right track, but new panel seems a bit too vague. What is
going to happen when they will change the panel again?

pinetab-early-adopter seems more robust there

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)