linux-kernel - Re: arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201214111216.GA41558@C02TD0UTHF1T.local>
Date:   Mon, 14 Dec 2020 11:12:25 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, James Morse <james.morse@....com>
Subject: Re: arch/arm64/kernel/entry-common.c:68:25: warning: no previous
 prototype for 'el1_sync_handler'

On Mon, Dec 14, 2020 at 10:28:48AM +0000, Catalin Marinas wrote:
> On Mon, Dec 14, 2020 at 03:12:34PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   2c85ebc57b3e1817b6ce1a6b703928e113a90442
> > commit: ed3768db588291ddb5dc794daed12cc751373566 arm64: entry: convert el1_sync to C
> > date:   1 year, 2 months ago
> > config: arm64-randconfig-r021-20201214 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed3768db588291ddb5dc794daed12cc751373566
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout ed3768db588291ddb5dc794daed12cc751373566
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler' [-Wmissing-prototypes]
> >       68 | asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
> 
> Do we actually need to fix these? It's asmlinkage and called from
> assembly, it wouldn't understand a prototype anyway.

Given we do this for a few other asmlinkage functions in this area, I'll
spin a patch to add the few missing entry-common.c prototypes to
asm/exception.h for consistency.

It's not strictly necessary, but it's vastly less effort than fighting
the testing systems. ;)

Thanks,
Mark.