linux-kernel - Re: [PATCH v4] Serial: silabs si4455 serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214123519.GA10229@dev>
Date:   Mon, 14 Dec 2020 12:35:20 +0000
From:   József Horváth <info@...istro.hu>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
        'Rob Herring' <robh+dt@...nel.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Serial: silabs si4455 serial driver

On Mon, Dec 14, 2020 at 09:04:13AM +0100, Jiri Slaby wrote:
> On 12. 12. 20, 8:09, József Horváth wrote:
> > This is a serial port driver for
> >   Silicon Labs Si4455 Sub-GHz transciver.
> > 
> > The goal of this driver is to removing wires
> >   between central(linux) device and remote serial devices/sensors,
> >   but keeping the original user software.
> >   It represents regular serial interface for the user space.
> > 
> > Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
> 
> A description of changes between v1..v4 here, please.
> 
> > Signed-off-by: József Horváth <info@...istro.hu>
> ...
> 
> spi_register_driver can fail too.
> 
> > +
> > +	return 0;
> > +}
> 
> regards,
> -- 
> js

Thank you for your suggestions.

I'm in trouble with the device tree binding schema of this driver too.

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/serial/,
 it completes successfully.

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/staging/serial/,
 the make dt_binding_check output:

	Unknown file referenced: [Errno 2] No such file or directory: '/home/administrator/.local/lib/python3.6/site-packages/dtschema/schemas/staging/serial/serial.yaml'
	xargs: dt-doc-validate: exited with status 255; aborting
	Documentation/devicetree/bindings/Makefile:59: recipe for target 'Documentation/devicetree/bindings/processed-schema-examples.json' failed
	make[1]: *** [Documentation/devicetree/bindings/processed-schema-examples.json] Error 124
	Makefile:1364: recipe for target 'dt_binding_check' failed
	make: *** [dt_binding_check] Error 2

When I run "make dt_binding_check" with $id: "http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#" in schema,
 and silabs,si4455.yaml is under Documentation/devicetree/bindings/staging/serial/,
 and removed $ref: "serial.yaml#".
 The make dt_binding_check completes successfully, but this is not a good solution.

My question is, how can I use $ref: "serial.yaml" dependency in silabs,si4455.yaml, while my schema is under staging?
        allOf:
          - $ref: "serial.yaml#"

If you have any suggestion that brings me to the right direction it would be great. 

Üdvözlettel / Best regards:
József Horváth