linux-kernel - Re: [PATCH] mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201214134116.GC9673@ediswmail.ad.cirrus.com>
Date:   Mon, 14 Dec 2020 13:41:16 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        Samuel Ortiz <sameo@...ux.intel.com>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] mfd: wm831x-auxadc: Prevent use after free in
 wm831x_auxadc_read_irq()

On Mon, Dec 14, 2020 at 02:59:10PM +0300, Dan Carpenter wrote:
> The "req" struct is always added to the "wm831x->auxadc_pending" list,
> but it's only removed from the list on the success path.  If a failure
> occurs then the "req" struct is freed but it's still on the list,
> leading to a use after free.
> 
> Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles