linux-kernel - Re: [PATCH] counter:ti-eqep: remove floor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88a5ed56-ac49-bf64-4d52-8ada6d3af4ef@lechnology.com>
Date:   Mon, 14 Dec 2020 08:05:44 -0600
From:   David Lechner <david@...hnology.com>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     linux-iio@...r.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] counter:ti-eqep: remove floor

On 12/14/20 5:46 AM, William Breathitt Gray wrote:
> On Sun, Dec 13, 2020 at 06:09:27PM -0600, David Lechner wrote:
>> The hardware doesn't support this. QPOSINIT is an initialization value
>> that is triggered by other things. When the counter overflows, it
>> always wraps around to zero.
>>
>> Fixes: f213729f6796 "counter: new TI eQEP driver"
>> Signed-off-by: David Lechner <david@...hnology.com>
> 
> Is the QPOSINIT preprocessor define needed at all anymore, or should it also be
> removed?

There are already many more defines for registers that are not
used, so I didn't remove it.

> 
> Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>
> 
>> ---
>>   drivers/counter/ti-eqep.c | 35 -----------------------------------
>>   1 file changed, 35 deletions(-)
>>
>> diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
>> index a60aee1a1a29..65df9ef5b5bc 100644
>> --- a/drivers/counter/ti-eqep.c
>> +++ b/drivers/counter/ti-eqep.c
>> @@ -235,36 +235,6 @@ static ssize_t ti_eqep_position_ceiling_write(struct counter_device *counter,
>>   	return len;
>>   }
>>   
>> -static ssize_t ti_eqep_position_floor_read(struct counter_device *counter,
>> -					   struct counter_count *count,
>> -					   void *ext_priv, char *buf)
>> -{
>> -	struct ti_eqep_cnt *priv = counter->priv;
>> -	u32 qposinit;
>> -
>> -	regmap_read(priv->regmap32, QPOSINIT, &qposinit);
>> -
>> -	return sprintf(buf, "%u\n", qposinit);
>> -}
>> -
>> -static ssize_t ti_eqep_position_floor_write(struct counter_device *counter,
>> -					    struct counter_count *count,
>> -					    void *ext_priv, const char *buf,
>> -					    size_t len)
>> -{
>> -	struct ti_eqep_cnt *priv = counter->priv;
>> -	int err;
>> -	u32 res;
>> -
>> -	err = kstrtouint(buf, 0, &res);
>> -	if (err < 0)
>> -		return err;
>> -
>> -	regmap_write(priv->regmap32, QPOSINIT, res);
>> -
>> -	return len;
>> -}
>> -
>>   static ssize_t ti_eqep_position_enable_read(struct counter_device *counter,
>>   					    struct counter_count *count,
>>   					    void *ext_priv, char *buf)
>> @@ -301,11 +271,6 @@ static struct counter_count_ext ti_eqep_position_ext[] = {
>>   		.read	= ti_eqep_position_ceiling_read,
>>   		.write	= ti_eqep_position_ceiling_write,
>>   	},
>> -	{
>> -		.name	= "floor",
>> -		.read	= ti_eqep_position_floor_read,
>> -		.write	= ti_eqep_position_floor_write,
>> -	},
>>   	{
>>   		.name	= "enable",
>>   		.read	= ti_eqep_position_enable_read,
>> -- 
>> 2.25.1
>>