linux-kernel - Re: [PATCH v1 1/4] devicetree: phy: rockchip-emmc optional add vendor prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL0WF-VwnaqhgQyYP0A-2Xp_q==zAw9jS5eoD3P6PmF-A@mail.gmail.com>
Date:   Mon, 14 Dec 2020 08:10:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Chris Ruehl <chris.ruehl@...ys.com.hk>
Cc:     devicetree@...r.kernel.org, Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v1 1/4] devicetree: phy: rockchip-emmc optional add vendor prefix

On Sun, Dec 13, 2020 at 9:00 PM Chris Ruehl <chris.ruehl@...ys.com.hk> wrote:
>
> Update the documentation and add the vendor prefix to the optional
> properties referred in vendor-prefixes.yaml.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@...ys.com.hk>
> ---
>  .../bindings/phy/rockchip-emmc-phy.txt        | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> index 00aa2d349e55..3a55d8086868 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> @@ -13,14 +13,15 @@ Optional properties:
>                 access to it), it is strongly suggested.
>                 See ../clock/clock-bindings.txt for details.
>   - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
> - - drive-impedance-ohm: Specifies the drive impedance in Ohm.
> -                        Possible values are 33, 40, 50, 66 and 100.
> -                        If not set, the default value of 50 will be applied.
> - - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
> -                           If not set, pull-down is not used.
> - - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
> -                           If not set, the register defaults to 0x4.
> -                           Maximum value 0xf.
> + - rockchip,drive-impedance-ohm: Specifies the drive impedance in Ohm.
> +                                 Possible values are 33, 40, 50, 66 and 100.
> +                                 If not set, the default value of 50 will be
> +                                 applied.

You can't change this one, it's already an ABI. Only what just got
queued can be changed.

> + - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
> +                                    line.  If not set, pull-down is not used.
> + - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
> +                                    If not set, the register defaults to 0x4.
> +                                    Maximum value 0xf.
>
>  Example:
>
> @@ -37,7 +38,7 @@ grf: syscon@...70000 {
>                 reg = <0xf780 0x20>;
>                 clocks = <&sdhci>;
>                 clock-names = "emmcclk";
> -               drive-impedance-ohm = <50>;
> +               rockchip,drive-impedance-ohm = <50>;
>                 #phy-cells = <0>;
>         };
>  };
> --
> 2.20.1
>